netdev - Re: [PATCH net-next v1 05/14] amd-xgbe: Add additional debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170817.220203.1607309698344574831.davem@davemloft.net>
Date:   Thu, 17 Aug 2017 22:02:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     thomas.lendacky@....com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1 05/14] amd-xgbe: Add additional debugfs
 support

From: Andrew Lunn <andrew@...n.ch>
Date: Fri, 18 Aug 2017 02:30:57 +0200

> On Thu, Aug 17, 2017 at 07:02:50PM -0500, Tom Lendacky wrote:
>> Add additional debugfs support for reading / writing registers of any
>> attached external phy devices as well as the SFP eeprom data.
> 
> Hi Tom
> 
> What is wrong with using the standard APIs for this?
> 
> ethtool --moduile-info
> 
> ioctls SIOCGMIIREG and SIOCSMIIREG.

Yeah debugfs is a horrible choice for this.

debugfs in general should be strongly avoided.  We have rich eneough
facilities to export just about anything that is actually appropriate
and useful, and where we do not existing facilities should be extended
as needed rather than ignored.