netdev - Re: [PATCH net-next] cxgb4/cxgbvf: Handle 32-bit fw port capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170819.213430.892558113817773681.davem@davemloft.net>
Date:   Sat, 19 Aug 2017 21:34:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ganeshgr@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, leedom@...lsio.com, venkatesh@...lsio.com
Subject: Re: [PATCH net-next] cxgb4/cxgbvf: Handle 32-bit fw port
 capabilities

From: David Miller <davem@...emloft.net>
Date: Sat, 19 Aug 2017 21:32:40 -0700 (PDT)

> From: Ganesh Goudar <ganeshgr@...lsio.com>
> Date: Fri, 18 Aug 2017 21:21:32 +0530
> 
>> Implement new 32-bit Firmware Port Capabilities in order to
>> handle new speeds which couldn't be represented in the old 16-bit
>> Firmware Port Capabilities values.
>> 
>> Based on the original work of Casey Leedom <leedom@...lsio.com>
>> 
>> Signed-off-by: Ganesh Goudar <ganeshgr@...lsio.com>
> 
> Applied.

Reverted, this doesn't even build!

[davem@...alhost net-next]$ make -s -j8
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c: In function ‘fwevtq_handler’:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:534:50: error: expected ‘)’ before ‘{’ token
        action == FW_PORT_ACTION_GET_PORT_INFO32) {
                                                  ^
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:560:2: error: expected expression before ‘}’ token
  } else if (opcode == CPL_L2T_WRITE_RPL) {
  ^
At top level:
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:463:13: warning: ‘dcb_rpl’ defined but not used [-Wunused-function]
 static void dcb_rpl(struct adapter *adap, const struct fw_port_cmd *pcmd)
             ^~~~~~~
make[5]: *** [scripts/Makefile.build:303: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.o] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [scripts/Makefile.build:561: drivers/net/ethernet/chelsio/cxgb4] Error 2
make[3]: *** [scripts/Makefile.build:561: drivers/net/ethernet/chelsio] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:561: drivers/net/ethernet] Error 2
make[1]: *** [scripts/Makefile.build:561: drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1019: drivers] Error 2