netdev - Re: [PATCH] tools lib bpf: improve warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170821004436.uygqfpkc6wgdmqmt@ast-mbp>
Date:   Sun, 20 Aug 2017 17:44:38 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Eric Leblond <eric@...it.org>
Cc:     netdev@...r.kernel.org, Wangnan <wangnan0@...wei.com>
Subject: Re: [PATCH] tools lib bpf: improve warning

On Sun, Aug 20, 2017 at 09:48:14PM +0200, Eric Leblond wrote:
> Signed-off-by: Eric Leblond <eric@...it.org>
> ---
>  tools/lib/bpf/libbpf.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 1cc3ea0ffdc3..35f6dfcdc565 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -879,7 +879,8 @@ bpf_object__create_maps(struct bpf_object *obj)
>  			size_t j;
>  			int err = *pfd;
>  
> -			pr_warning("failed to create map: %s\n",
> +			pr_warning("failed to create map (name: '%s'): %s\n",
> +				   obj->maps[i].name,
>  				   strerror(errno));

makes sense.
Acked-by: Alexei Starovoitov <ast@...nel.org>
Please cc Wang for future libbpf patches.