netdev - Re: [PATCH] net_sched/hhf: update hierarchical backlog when drop packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpV+XEnef522viC0xBLYJ+EzVJy_LHaDmSZJcUqczJcNuQ@mail.gmail.com>
Date:   Mon, 21 Aug 2017 10:03:08 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH] net_sched/hhf: update hierarchical backlog when drop packet

On Mon, Aug 21, 2017 at 9:56 AM, Konstantin Khlebnikov
<khlebnikov@...dex-team.ru> wrote:
> Current packet wouldn't be counted by parent either. So queue length isn't
> changed.
>

But the qdisc_tree_reduce_backlog() right below uses 1 too:


        /* As we dropped a packet, better let upper stack know this. */
        qdisc_tree_reduce_backlog(sch, 1, prev_backlog - sch->qstats.backlog);
        return NET_XMIT_SUCCESS;