netdev - Re: [PATCH net-next] net: sched: Add the invalid handle check in qdisc_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170821.104749.419102990180912192.davem@davemloft.net>
Date:   Mon, 21 Aug 2017 10:47:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gfree.wind@....163.com
Cc:     netdev@...r.kernel.org, xiyou.wangcong@...il.com, jhs@...atatu.com
Subject: Re: [PATCH net-next] net: sched: Add the invalid handle check in
 qdisc_class_find

From: gfree.wind@....163.com
Date: Fri, 18 Aug 2017 15:23:24 +0800

> From: Gao Feng <gfree.wind@....163.com>
> 
> Add the invalid handle "0" check to avoid unnecessary search, because
> the qdisc uses the skb->priority as the handle value to look up, and
> it is "0" usually.
> 
> Signed-off-by: Gao Feng <gfree.wind@....163.com>

Jamal, Cong, please review.

If 'id' zero is never hashed into the tables, this change looks
legitimate.