netdev - Re: [PATCH net-next] net: check type when freeing metadata dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170821.105757.389405605152815901.davem@davemloft.net>
Date:   Mon, 21 Aug 2017 10:57:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     equinox@...c24.net
Cc:     netdev@...r.kernel.org, jakub.kicinski@...ronome.com,
        sridhar.samudrala@...el.com, horms@...ge.net.au
Subject: Re: [PATCH net-next] net: check type when freeing metadata dst

From: David Lamparter <equinox@...c24.net>
Date: Fri, 18 Aug 2017 14:31:35 +0200

> Commit 3fcece12bc1b ("net: store port/representator id in metadata_dst")
> added a new type field to metadata_dst, but metadata_dst_free() wasn't
> updated to check it before freeing the METADATA_IP_TUNNEL specific dst
> cache entry.
> 
> This is not currently causing problems since it's far enough back in the
> struct to be zeroed for the only other type currently in existance
> (METADATA_HW_PORT_MUX), but nevertheless it's not correct.
> 
> Fixes: 3fcece12bc1b ("net: store port/representator id in metadata_dst")
> Signed-off-by: David Lamparter <equinox@...c24.net>

Applied.