netdev - Re: [PATCH net-next] net: sched: Add the invalid handle check in qdisc_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13811d3e-9800-8277-c861-2fab9de8e4b9@mojatatu.com>
Date:   Mon, 21 Aug 2017 16:17:01 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        David Miller <davem@...emloft.net>
Cc:     Gao Feng <gfree.wind@....163.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: sched: Add the invalid handle check in
 qdisc_class_find

On 17-08-21 03:58 PM, Cong Wang wrote:
> On Mon, Aug 21, 2017 at 10:47 AM, David Miller <davem@...emloft.net> wrote:
>> From: gfree.wind@....163.com
>> Date: Fri, 18 Aug 2017 15:23:24 +0800
>>
>>> From: Gao Feng <gfree.wind@....163.com>
>>>
>>> Add the invalid handle "0" check to avoid unnecessary search, because
>>> the qdisc uses the skb->priority as the handle value to look up, and
>>> it is "0" usually.
>>>
>>> Signed-off-by: Gao Feng <gfree.wind@....163.com>
>>
>> Jamal, Cong, please review.
>>
>> If 'id' zero is never hashed into the tables, this change looks
>> legitimate.
> 
> Looks good to me.
>

Looks good to me as well...

cheers,
jamal