netdev - Re:Re: [PATCH net-next] net: sched: Add the invalid handle check in qdisc_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <caf756f.76ba.15e0767aea0.Coremail.gfree.wind@vip.163.com>
Date:   Tue, 22 Aug 2017 08:46:29 +0800 (CST)
From:   "Gao Feng" <gfree.wind@....163.com>
To:     "Cong Wang" <xiyou.wangcong@...il.com>
Cc:     "David Miller" <davem@...emloft.net>,
        "Linux Kernel Network Developers" <netdev@...r.kernel.org>,
        "Jamal Hadi Salim" <jhs@...atatu.com>
Subject: Re:Re: [PATCH net-next] net: sched: Add the invalid handle check in
 qdisc_class_find

At 2017-08-22 03:58:03, "Cong Wang" <xiyou.wangcong@...il.com> wrote:
>On Mon, Aug 21, 2017 at 10:47 AM, David Miller <davem@...emloft.net> wrote:
>> From: gfree.wind@....163.com
>> Date: Fri, 18 Aug 2017 15:23:24 +0800
>>
>>> From: Gao Feng <gfree.wind@....163.com>
>>>
>>> Add the invalid handle "0" check to avoid unnecessary search, because
>>> the qdisc uses the skb->priority as the handle value to look up, and
>>> it is "0" usually.
>>>
>>> Signed-off-by: Gao Feng <gfree.wind@....163.com>
>>
>> Jamal, Cong, please review.
>>
>> If 'id' zero is never hashed into the tables, this change looks
>> legitimate.
>
>Looks good to me.
>
>Gao, in the future please Cc maintainers directly, you can
>use ./scripts/get_maintainer.pl.
>
>Thanks.

Hi Cong,

Thanks your reminder firstly.
But I had used the get_maintainer.pl actually before sent the patch.

The following is the output.
[fgao@...ai8 net-next]#./scripts/get_maintainer.pl patch_ScheCheck/0001-net-sched-Add-the-invalid-handle-check-in-qdisc_clas.patch
"David S. Miller" <davem@...emloft.net> (maintainer:NETWORKING [GENERAL])
netdev@...r.kernel.org (open list:NETWORKING [GENERAL])
linux-kernel@...r.kernel.org (open list)

I don't know if it is an issue of the script "get_maintainer.pl"  or my usage is wrong.

Anyway, thanks you & Jamal's review.

Best Regards
Feng