netdev - Re: [PATCH net] net/hsr: Check skb_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170822.134943.186346483000054388.davem@davemloft.net>
Date:   Tue, 22 Aug 2017 13:49:43 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, mail@...ise.de, peter.heise@...bus.com,
        arvid.brodin@...en.se, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net/hsr: Check skb_put_padto() return value

From: Florian Fainelli <f.fainelli@...il.com>
Date: Mon, 21 Aug 2017 12:59:10 -0700

> skb_put_padto() will free the sk_buff passed as reference in case of
> errors, but we still need to check its return value and decide what to
> do.
> 
> Detected by CoverityScan, CID#1416688 ("CHECKED_RETURN")
> 
> Fixes: ee1c27977284 ("net/hsr: Added support for HSR v1")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks.