netdev - Re: [PATCH v2 net-next 2/2] selftests/net: Add a test to validate behavior of rx timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF=yD-+_6s=ePCvn6i7+a+DETSmqtLE23mt6rUtXhfWnCKz7og@mail.gmail.com>
Date:   Tue, 22 Aug 2017 17:39:14 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Mike Maloney <maloneykernel@...il.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Mike Maloney <maloney@...gle.com>
Subject: Re: [PATCH v2 net-next 2/2] selftests/net: Add a test to validate
 behavior of rx timestamps

On Tue, Aug 22, 2017 at 5:08 PM, Mike Maloney <maloneykernel@...il.com> wrote:
> From: Mike Maloney <maloney@...gle.com>
>
> Validate the behavior of the combination of various timestamp socket
> options, and ensure consistency across ip, udp, and tcp.
>
> Signed-off-by: Mike Maloney <maloney@...gle.com>

Acked-by: Willem de Bruijn <willemb@...gle.com>

Thanks for adding these tests.

For tcp, it may be useful to eventually also add packetdrill tests
to validate the more subtle semantics, such as that the timestamp is
returned only when reading the last byte of the skb.

> +       do_send(src);
> +
> +       if (s.type == SOCK_RAW)
> +               read_size += 20;  /* for IP header */

No need to revise just for this, but if submitting a v3:

please use sizeof(struct iphdr). And maybe test PF_INET6, too.