netdev - Re: [PATCH net-next 1/3 v7] net: ether: Add support for multiplexing and aggregation type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e0f6382e5770bb32efa342b1fe5cc81@codeaurora.org>
Date:   Mon, 21 Aug 2017 23:27:13 -0600
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        fengguang.wu@...el.com, dcbw@...hat.com, jiri@...nulli.us,
        stephen@...workplumber.org, David.Laight@...lab.com,
        marcel@...tmann.org, netdev-owner@...r.kernel.org
Subject: Re: [PATCH net-next 1/3 v7] net: ether: Add support for multiplexing
 and aggregation type

>> +#define ETH_P_MAP       0xDA1A          /* Multiplexing and 
>> Aggregation Protocol
>> +					 *  NOT AN OFFICIALLY REGISTERED ID ]
>> +					 */
> 
> Hi Subash
> 
> This list is sorted. So this entry should go earlier.
> 
>> +	netdev_info(real_dev, "Removed from rmnet\n");
> 
> I would probably turn all your netdev_info()s into netdev_dbg()s.  You
> seem to be spamming the kernel log quite a bit.
> 

Hi Andrew

I'll make these changes and post v8.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project