netdev - Re: [PATCH net-next 3/3 v5] drivers: net: ethernet: qualcomm: rmnet: Initial implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <189aff978eef108edaf9872c50f1f19f@codeaurora.org>
Date:   Mon, 21 Aug 2017 23:34:07 -0600
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        fengguang.wu@...el.com, dcbw@...hat.com, jiri@...nulli.us,
        David.Laight@...lab.com, marcel@...tmann.org
Subject: Re: [PATCH net-next 3/3 v5] drivers: net: ethernet: qualcomm: rmnet:
 Initial implementation

>> +	priv = netdev_priv(rmnet_dev);
>> +	memset(priv, 0, sizeof(struct rmnet_priv));
> 
> Netdev private area is always zero on creation. See alloc_netdev().
> 
>> +	if (!rmnet_dev)
>> +		return 0;
> 
> Do not confuse 0 with NULL. Did you run sparse?
> 
>> +
>> +	priv = netdev_priv(rmnet_dev);
>> +	if (!priv)
>> +		return 0;
> 
> 
> netdev_priv() always returns a non-NULL value.  The private area is 
> just
> a constant offset below the original network_device structure.

Hi Stephen

I havent used sparse till now. I'll fix the errors reported by it as 
well
your other comments and post again.


--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project