netdev - Re: [PATCH V8 net-next 00/22] Huawei HiNIC Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a0St2mZ7q33zccHZ1uPyv0FKf2A+q+cMk+LN_L_qjxfkg@mail.gmail.com>
Date:   Wed, 23 Aug 2017 12:37:31 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Aviad Krawczyk <aviad.krawczyk@...wei.com>
Cc:     David Miller <davem@...emloft.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>, bc.y@...wei.com,
        victor.gissin@...wei.com, zhaochen6@...wei.com, tony.qu@...wei.com
Subject: Re: [PATCH V8 net-next 00/22] Huawei HiNIC Ethernet Driver

On Wed, Aug 23, 2017 at 11:31 AM, Aviad Krawczyk
<aviad.krawczyk@...wei.com> wrote:
> Hi Arnd,
>
> This is Huawei's PCIE HiNIC card.
>
> I am not familiar with the HiSilicon product and I don't see how
> Huawei's PCIE HiNIC card is connected to the HiSilicon drivers on Linux Tree.
>
> I don't see how it can be shared: different product and different code.

Sharing code was just a wild thought of mine, as I said I had not looked at
whether there is anything that can be shared.

However, simply moving drivers/net/ethernet/huawei/hinic to
drivers/net/ethernet/hisilicon/hinic/ still seems to be the right thing and
is a trivial patch.

It's clear that hinic is made by HiSilicon and that hns/hns3 are used
exclusively in Huawei, and maintained by Huawei developers, so it's
probably just a matter of time before the IP block from the SoC makes
it into a future PCI device or vice versa. Merging the two directories
now makes this easier to handle in the future and (slightly) reduces
the clutter in the top-level drivers/net/ethernet/Kconfig file.

     Arnd