netdev - Re: Stable apply request [was: Bluetooth: bnep: fix possible might sleep error in bnep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E0E7758A-9E4C-4179-8403-D8895424586B@holtmann.org>
Date:   Wed, 23 Aug 2017 20:14:15 +0200
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     Jeffy Chen <jeffy.chen@...k-chips.com>,
        stable <stable@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:BLUETOOTH DRIVERS" <linux-bluetooth@...r.kernel.org>,
        rvaswani@...dia.com, Brian Norris <briannorris@...omium.org>,
        dmitry.torokhov@...il.com,
        Douglas Anderson <dianders@...omium.org>, acho@...e.com,
        Johan Hedberg <johan.hedberg@...il.com>,
        Network Development <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Gustavo F. Padovan" <gustavo@...ovan.org>
Subject: Re: Stable apply request [was: Bluetooth: bnep: fix possible might
 sleep error in bnep_session]

Hi Jiri,

>>> It looks like bnep_session has same pattern as the issue reported in
>>> old rfcomm:
>>> 
>>> 	while (1) {
>>> 		set_current_state(TASK_INTERRUPTIBLE);
>>> 		if (condition)
>>> 			break;
>>> 		// may call might_sleep here
>>> 		schedule();
>>> 	}
>>> 	__set_current_state(TASK_RUNNING);
>>> 
>>> Which fixed at:
>>> 	dfb2fae Bluetooth: Fix nested sleeps
>>> 
>>> So let's fix it at the same way, also follow the suggestion of:
>>> https://lwn.net/Articles/628628/
> 
> ...
> 
>> all 3 patches have been applied to bluetooth-next tree.
> 
> Hi,
> 
> given users are hitting it in at least 4.4 and 4.12, can we have all
> three in all stables where this applies?
> 
> 5da8e47d849d Bluetooth: hidp: fix possible might sleep error in
> hidp_session_thread
> f06d977309d0 Bluetooth: cmtp: fix possible might sleep error in cmtp_session
> 25717382c1dd Bluetooth: bnep: fix possible might sleep error in bnep_session
> 
> I am not sure: to stable directly or via net stable?

as Dave said, just email -stable directly and have Greg pick them up.

Regards

Marcel