netdev - Re: [PATCH v2 3/4] net: phy: realtek: add disable RX internal delay mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201708241013.Evo4jDXf%fengguang.wu@intel.com>
Date:   Thu, 24 Aug 2017 10:35:50 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Icenowy Zheng <icenowy@...c.io>
Cc:     kbuild-all@...org,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Corentin Labbe <clabbe.montjoie@...il.com>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-sunxi@...glegroups.com, Icenowy Zheng <icenowy@...c.xyz>
Subject: Re: [PATCH v2 3/4] net: phy: realtek: add disable RX internal delay
 mode

Hi Icenowy,

[auto build test WARNING on net-next/master]
[also build test WARNING on v4.13-rc6 next-20170823]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Icenowy-Zheng/Workaround-broken-RTL8211E-on-some-Pine64-boards/20170823-234405
config: x86_64-randconfig-b0-08240928 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/net/phy/realtek.c: In function 'rtl8211e_config_init':
>> drivers/net/phy/realtek.c:130: warning: unused variable 'of_node'

vim +/of_node +130 drivers/net/phy/realtek.c

   126	
   127	static int rtl8211e_config_init(struct phy_device *phydev)
   128	{
   129		struct device *dev = &phydev->mdio.dev;
 > 130		struct device_node *of_node = dev->of_node;
   131		int ret;
   132	
   133		ret = genphy_config_init(phydev);
   134		if (ret < 0)
   135			return ret;
   136	
   137		if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) {
   138			/* Disable the RX internal delay here.
   139			 *
   140			 * All the magic numbers are not documented on RTL8211E
   141			 * datasheet. They're said to be from Realtek by Pine64.
   142			 */
   143			phy_write(phydev, RTL8211_PAGE_SELECT, RTL8211E_EXT_PAGE);
   144			phy_write(phydev, RTL8211E_EXT_PAGE_SELECT, 0xa4);
   145			phy_write(phydev, 0x1c, 0xb591);
   146	
   147			/* Restore to default page 0 */
   148			phy_write(phydev, RTL8211_PAGE_SELECT, 0);
   149		}
   150	
   151		return 0;
   152	}
   153	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32072 bytes)