netdev - Re: [PATCH net-next] liquidio: change manner of detecting whether or not NIC firmware is loaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170823.202945.1564592947856218029.davem@davemloft.net>
Date:   Wed, 23 Aug 2017 20:29:45 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     felix.manlunas@...ium.com
Cc:     netdev@...r.kernel.org, raghu.vatsavayi@...ium.com,
        derek.chickles@...ium.com, satananda.burla@...ium.com
Subject: Re: [PATCH net-next] liquidio: change manner of detecting whether
 or not NIC firmware is loaded

From: Felix Manlunas <felix.manlunas@...ium.com>
Date: Tue, 22 Aug 2017 12:46:37 -0700

> In the NIC firmware, the 1-bit flag indicating "firmware is loaded" moved
> from SLI_SCRATCH_1 to SLI_SCRATCH_2 (these are Octeon general-purpose
> scratch registers).  Make the PF driver conform to this change.
> 
> Remove code that sets the "firmware is loaded" flag because it's now the
> firmware's job to do that.
> 
> In the code that detects whether or not the firmware is loaded, don't just
> rely on checking the "firmware is loaded" flag because that may cause a
> rare false negative.  Add code that deduces whether or not the firmware is
> loaded; that will never give a false negative.
> 
> Also bump up driver version to match newer NIC firmware.
> 
> Signed-off-by: Felix Manlunas <felix.manlunas@...ium.com>
> Signed-off-by: Derek Chickles <derek.chickles@...ium.com>

Applied.