netdev - Re: [PATCH net-next] ipv4: do metrics match when looking up and deleting a route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170823.203800.2128849794896344817.davem@davemloft.net>
Date:   Wed, 23 Aug 2017 20:38:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, hannes@...essinduktion.org
Subject: Re: [PATCH net-next] ipv4: do metrics match when looking up and
 deleting a route

From: Xin Long <lucien.xin@...il.com>
Date: Wed, 23 Aug 2017 10:07:26 +0800

> Now when ipv4 route inserts a fib_info, it memcmp fib_metrics.
> It means ipv4 route identifies one route also with metrics.
> 
> But when removing a route, it tries to find the route without
> caring about the metrics. It will cause that the route with
> right metrics can't be removed.
> 
> Thomas noticed this issue when doing the testing:
> 
> 1. add:
>    # ip route append 192.168.7.0/24 dev v window 1000
>    # ip route append 192.168.7.0/24 dev v window 1001
>    # ip route append 192.168.7.0/24 dev v window 1002
>    # ip route append 192.168.7.0/24 dev v window 1003
> 2. delete:
>    # ip route delete 192.168.7.0/24 dev v window 1002
> 3. show:
>      192.168.7.0/24 proto boot scope link window 1001
>      192.168.7.0/24 proto boot scope link window 1002
>      192.168.7.0/24 proto boot scope link window 1003
> 
> The one with window 1002 wasn't deleted but the first one was.
> 
> This patch is to do metrics match when looking up and deleting
> one route.
> 
> Reported-by: Thomas Haller <thaller@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> Acked-by: Hannes Frederic Sowa <hannes@...essinduktion.org>

Applied.