netdev - Re: [PATCH net] bpf: fix bpf_setsockopts return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26CD0A38-4AC2-4D37-90A2-D4AEDEBC91FA@fb.com>
Date:   Thu, 24 Aug 2017 23:45:22 +0000
From:   Lawrence Brakmo <brakmo@...com>
To:     Daniel Borkmann <daniel@...earbox.net>,
        Yuchung Cheng <ycheng@...gle.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "ncardwell@...gle.com" <ncardwell@...gle.com>,
        "cgallek@...gle.com" <cgallek@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] bpf: fix bpf_setsockopts return value



On 8/24/17, 4:37 PM, "Daniel Borkmann" <daniel@...earbox.net> wrote:

    On 08/25/2017 12:48 AM, Yuchung Cheng wrote:
    > This patch fixes a bug causing any sock operations to always return EINVAL.
    >
    > Fixes: a5192c52377e ("bpf: fix to bpf_setsockops").
    > Reported-by: Neal Cardwell <ncardwell@...gle.com>
    > Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
    > Acked-by: Neal Cardwell <ncardwell@...gle.com>
    > Acked-by: Craig Gallek <kraig@...gle.com>
    
    Ohh well, thanks for the fix!
    
    Acked-by: Daniel Borkmann <daniel@...earbox.net>

Thanks! I never checked return values in by bpf test programs

Acked-by: Lawrence Brakmo <brakmo@...com>