netdev - Re: [PATCH net 4/7] net:ethernet:aquantia: Fix for MCP state change.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170823.221717.808276378249736288.davem@davemloft.net>
Date:   Wed, 23 Aug 2017 22:17:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Pavel.Belous@...antia.com
Cc:     netdev@...r.kernel.org, darcari@...hat.com,
        Igor.Russkikh@...antia.com, Nadezhda.Krupnina@...antia.com,
        simon.edelhaus@...antia.com
Subject: Re: [PATCH net 4/7] net:ethernet:aquantia: Fix for MCP state
 change.

From: Pavel Belous <Pavel.Belous@...antia.com>
Date: Wed, 23 Aug 2017 17:05:05 +0300

> diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h
> index a66aee5..fc69408a 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h
> +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.h
> @@ -160,6 +160,19 @@ enum hal_atl_utils_fw_state_e {
>  	MPI_POWER = 4,
>  };
>  
> +union hal_atl_utils_hw_mpi_state_reg {
> +	u32 val;
> +	struct {
> +		u8 e_state;
> +		u8 reserved1;
> +		u8 u_speed;
> +		u8 reserved2:1;
> +		u8 disable_dirty_wake:1;
> +		u8 reserved3:2;
> +		u8 u_downshift:4;
> +	};
> +};
> +

You need to consider endianness when declaring bitfields in C.

Seriously, I'd rather you simply fixed the shifts and masks into the
u32 value than going down this route.