netdev - Re: [PATCH net] nfp: TX time stamp packets before HW doorbell is rung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170823.224128.1575286278485663410.davem@davemloft.net>
Date:   Wed, 23 Aug 2017 22:41:28 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH net] nfp: TX time stamp packets before HW doorbell is
 rung

From: Jakub Kicinski <jakub.kicinski@...ronome.com>
Date: Wed, 23 Aug 2017 14:41:50 -0700

> TX completion may happen any time after HW queue was kicked.
> We can't access the skb afterwards.  Move the time stamping
> before ringing the doorbell.
> 
> Fixes: 4c3523623dc0 ("net: add driver for Netronome NFP4000/NFP6000 NIC VFs")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Simon Horman <simon.horman@...ronome.com>

Applied, thanks.

If I had a nickel for every time this mistake was made...