netdev - Re: [PATCH] net/mlx4_core: make mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac5b8b4a-edf3-604b-63c5-5ff645e0c5bc@mellanox.com>
Date:   Thu, 24 Aug 2017 12:04:32 +0300
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        tariqt@...lanox.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/mlx4_core: make mlx4_profile const



On 23/08/2017 3:47 PM, Bhumika Goyal wrote:
> Make these const as they are only used in a copy operation.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/main.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index 541ce9e..43fb2eb 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -121,7 +121,7 @@
>   	DRV_NAME ": Mellanox ConnectX core driver v"
>   	DRV_VERSION "\n";
>   
> -static struct mlx4_profile default_profile = {
> +static const struct mlx4_profile default_profile = {
>   	.num_qp		= 1 << 18,
>   	.num_srq	= 1 << 16,
>   	.rdmarc_per_qp	= 1 << 4,
> @@ -131,7 +131,7 @@
>   	.num_mtt	= 1 << 20, /* It is really num mtt segements */
>   };
>   
> -static struct mlx4_profile low_mem_profile = {
> +static const struct mlx4_profile low_mem_profile = {
>   	.num_qp		= 1 << 17,
>   	.num_srq	= 1 << 6,
>   	.rdmarc_per_qp	= 1 << 4,
> 

Thanks Bhumika.

Reviewed-by: Tariq Toukan <tariqt@...lanox.com>