netdev - Re: [PATCH net] cxgb4: Fix stack out-of-bounds read due to wrong size to t4_record

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR12MB1600CB171EE1C4F2961555B7C89B0@MWHPR12MB1600.namprd12.prod.outlook.com>
Date:   Fri, 25 Aug 2017 20:57:32 +0000
From:   Casey Leedom <leedom@...lsio.com>
To:     Stefano Brivio <sbrivio@...hat.com>,
        Ganesh GR <ganeshgr@...lsio.com>,
        "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Hariprasad Shenai <hariprasad@...lsio.com>,
        Sai Vemuri <svemuri@...hat.com>
Subject: Re: [PATCH net] cxgb4: Fix stack out-of-bounds read due to wrong size
 to t4_record_mbox()

| From: Stefano Brivio <sbrivio@...hat.com>
| Sent: Friday, August 25, 2017 1:48 PM
|     
| Passing commands for logging to t4_record_mbox() with size
| MBOX_LEN, when the actual command size is actually smaller,
| causes out-of-bounds stack accesses in t4_record_mbox() while
| copying command words here:
| ...

Thanks for catching this.  Definitely a bug.  Odd because
that's not what I checked into our out-of-kernel repository.
And the corresponding code in the cxgb4vf driver is correct.

So yes, ACK!

Casey