netdev - Re: [PATCH net-next v2] tg3: Be drop monitor friendly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLimXqzgpKRnPLjxyCUiyEDCYhNScp1qq1rv9gVWWZKGzBA@mail.gmail.com>
Date:   Thu, 24 Aug 2017 17:50:16 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>, edumazet@...il.com,
        Siva Reddy Kallam <siva.kallam@...adcom.com>,
        Prashant Sreedharan <prashant@...adcom.com>,
        Michael Chan <mchan@...adcom.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2] tg3: Be drop monitor friendly

On Thu, Aug 24, 2017 at 5:47 PM, Florian Fainelli <f.fainelli@...il.com> wrote:
> tg3_tx() does the normal packet TX completion,
> tigon3_dma_hwbug_workaround() and tg3_tso_bug() both need to allocate a
> new SKB that is suitable to workaround HW bugs, and finally
> tg3_free_rings() is doing ring cleanup. Use dev_consume_skb_any() for
> these 3 locations to be SKB drop monitor friendly.
>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Acked-by: Michael Chan <michael.chan@...adcom.com>

> ---
> Changes in v2:
>
> - also included tg3_tso_bug() as indicated by Michael
>