netdev - Re: [PATCH] strparser: initialize all callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170824.215827.1642146539202794550.davem@davemloft.net>
Date:   Thu, 24 Aug 2017 21:58:27 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ebiggers3@...il.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        ebiggers@...gle.com, dvyukov@...gle.com, tom@...ntonium.net
Subject: Re: [PATCH] strparser: initialize all callbacks

From: Eric Biggers <ebiggers3@...il.com>
Date: Thu, 24 Aug 2017 14:38:51 -0700

> From: Eric Biggers <ebiggers@...gle.com>
> 
> commit bbb03029a899 ("strparser: Generalize strparser") added more
> function pointers to 'struct strp_callbacks'; however, kcm_attach() was
> not updated to initialize them.  This could cause the ->lock() and/or
> ->unlock() function pointers to be set to garbage values, causing a
> crash in strp_work().
> 
> Fix the bug by moving the callback structs into static memory, so
> unspecified members are zeroed.  Also constify them while we're at it.
> 
> This bug was found by syzkaller, which encountered the following splat:
 ...
> Fixes: bbb03029a899 ("strparser: Generalize strparser")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

This commit is only in net-next, so that is where I am applying
this patch.

Thanks.