netdev - Re: [net-next:master 1324/1341] drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:323:9: error: too few arguments to function 'devlink_dpipe_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Aug 2017 18:11:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fengguang.wu@...el.com
Cc:     arkadis@...lanox.com, kbuild-all@...org, netdev@...r.kernel.org,
        jiri@...lanox.com
Subject: Re: [net-next:master 1324/1341]
 drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:323:9: error: too
 few arguments to function 'devlink_dpipe_table_register'

From: kbuild test robot <fengguang.wu@...el.com>
Date: Fri, 25 Aug 2017 08:03:28 +0800

> All errors (new ones prefixed by >>):
> 
>    drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c: In function 'mlxsw_sp_dpipe_erif_table_init':
>>> drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:323:9: error: too few arguments to function 'devlink_dpipe_table_register'
>      return devlink_dpipe_table_register(devlink,
>             ^
>    In file included from drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:36:0:
>    include/net/devlink.h:401:1: note: declared here
>     devlink_dpipe_table_register(struct devlink *devlink,
>     ^
>    drivers/net//ethernet/mellanox/mlxsw/spectrum_dpipe.c:327:1: warning: control reaches end of non-void function [-Wreturn-type]
>     }
>     ^

I'll push the following fix into net-next for this:

====================
>From 790c6056686cc4dd5b149b330bbd5ae208d4d721 Mon Sep 17 00:00:00 2001
From: "David S. Miller" <davem@...emloft.net>
Date: Thu, 24 Aug 2017 18:10:46 -0700
Subject: [PATCH] devlink: Fix devlink_dpipe_table_register() stub signature.

One too many arguments compared to the non-stub version.

Reported-by: kbuild test robot <fengguang.wu@...el.com>
Fixes: ffd3cdccf214 ("devlink: Add support for dynamic table size")
Signed-off-by: David S. Miller <davem@...emloft.net>
---
 include/net/devlink.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/net/devlink.h b/include/net/devlink.h
index 047a0c54f652..aaf7178127a2 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -402,8 +402,7 @@ static inline int
 devlink_dpipe_table_register(struct devlink *devlink,
 			     const char *table_name,
 			     struct devlink_dpipe_table_ops *table_ops,
-			     void *priv, u64 size,
-			     bool counter_control_extern)
+			     void *priv, bool counter_control_extern)
 {
 	return 0;
 }
-- 
2.13.5