netdev - Re: [patch net-next 11/12] mlxsw: spectrum_dpipe: Add support for IPv4 host table dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d5b031e-3d0a-624f-1285-9540a9dc4716@mellanox.com>
Date:   Fri, 25 Aug 2017 12:26:39 +0300
From:   Arkadi Sharshevsky <arkadis@...lanox.com>
To:     David Ahern <dsahern@...il.com>, Jiri Pirko <jiri@...nulli.us>,
        netdev@...r.kernel.org
Cc:     davem@...emloft.net, idosch@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net-next 11/12] mlxsw: spectrum_dpipe: Add support for
 IPv4 host table dump



On 08/24/2017 10:26 PM, David Ahern wrote:
> On 8/23/17 11:40 PM, Jiri Pirko wrote:
>> +static int
>> +mlxsw_sp_dpipe_table_host_entries_get(struct mlxsw_sp *mlxsw_sp,
>> +				      struct devlink_dpipe_entry *entry,
>> +				      bool counters_enabled,
>> +				      struct devlink_dpipe_dump_ctx *dump_ctx,
>> +				      int type)
>> +{
>> +	int rif_neigh_count = 0;
>> +	int rif_neigh_skip = 0;
>> +	int neigh_count = 0;
>> +	int rif_count;
>> +	int i, j;
>> +	int err;
>> +
>> +	rtnl_lock();
> 
> Why does a h/w driver dumping its tables need the rtnl lock?
> 

This table represents the hw IPv4 arp table, and the
driver depends on rtnl to be held.