lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 27 Aug 2017 18:31:22 +0200 From: Andrew Lunn <andrew@...n.ch> To: Pavel Machek <pavel@...x.de> Cc: Woojung.Huh@...rochip.com, nathan.leigh.conrad@...il.com, vivien.didelot@...oirfairelinux.com, f.fainelli@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Tristram.Ha@...rel.com Subject: Re: [PATCH] DSA support for Micrel KSZ8895 > +/** > + * sw_r_phy - read data from PHY register > + * @sw: The switch instance. > + * @phy: PHY address to read. > + * @reg: PHY register to read. > + * @val: Buffer to store the read data. > + * > + * This routine reads data from the PHY register. > + */ > +static void sw_r_phy(struct ksz_device *sw, u16 phy, u16 reg, u16 *val) > +{ > + u8 ctrl; > + u8 restart; > + u8 link; > + u8 speed; > + u8 force; > + u8 p = phy; > + u16 data = 0; > + > + switch (reg) { > + case PHY_REG_CTRL: > + ksz_pread8(sw, p, P_LOCAL_CTRL, &ctrl); > + ksz_pread8(sw, p, P_NEG_RESTART_CTRL, &restart); > + ksz_pread8(sw, p, P_SPEED_STATUS, &speed); > + ksz_pread8(sw, p, P_FORCE_CTRL, &force); > + if (restart & PORT_PHY_LOOPBACK) > + data |= PHY_LOOPBACK; > + if (force & PORT_FORCE_100_MBIT) > + data |= PHY_SPEED_100MBIT; > + if (!(force & PORT_AUTO_NEG_DISABLE)) > + data |= PHY_AUTO_NEG_ENABLE; > + if (restart & PORT_POWER_DOWN) > + data |= PHY_POWER_DOWN; > + if (restart & PORT_AUTO_NEG_RESTART) > + data |= PHY_AUTO_NEG_RESTART; > + if (force & PORT_FORCE_FULL_DUPLEX) > + data |= PHY_FULL_DUPLEX; > + if (speed & PORT_HP_MDIX) > + data |= PHY_HP_MDIX; > + if (restart & PORT_FORCE_MDIX) > + data |= PHY_FORCE_MDIX; > + if (restart & PORT_AUTO_MDIX_DISABLE) > + data |= PHY_AUTO_MDIX_DISABLE; > + if (restart & PORT_TX_DISABLE) > + data |= PHY_TRANSMIT_DISABLE; > + if (restart & PORT_LED_OFF) > + data |= PHY_LED_DISABLE; > + break; > + case PHY_REG_STATUS: > + ksz_pread8(sw, p, P_LINK_STATUS, &link); > + ksz_pread8(sw, p, P_SPEED_STATUS, &speed); > + data = PHY_100BTX_FD_CAPABLE | > + PHY_100BTX_CAPABLE | > + PHY_10BT_FD_CAPABLE | > + PHY_10BT_CAPABLE | > + PHY_AUTO_NEG_CAPABLE; > + if (link & PORT_AUTO_NEG_COMPLETE) > + data |= PHY_AUTO_NEG_ACKNOWLEDGE; > + if (link & PORT_STAT_LINK_GOOD) > + data |= PHY_LINK_STATUS; > + break; > + case PHY_REG_ID_1: > + data = KSZ8895_ID_HI; > + break; > + case PHY_REG_ID_2: > + data = KSZ8895_ID_LO; > + break; According to the datasheet, the PHY has the normal ID registers, which have the value 0x0022, 0x1450. So it should be possible to have a standard PHY driver in drivers/net/phy. In fact, the IDs suggest it is a micrel phy, and 1430, 1435 are already supported. So it could be you only need minor modifications to the micrel.c. Andrew
Powered by blists - more mailing lists