netdev - RE: [PATCH] DSA support for Micrel KSZ8895

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9235D6609DB808459E95D78E17F2E43D40B0BF9C@CHN-SV-EXMX02.mchp-main.com>
Date:   Sun, 27 Aug 2017 22:03:10 +0000
From:   <Woojung.Huh@...rochip.com>
To:     <pavel@...x.de>, <nathan.leigh.conrad@...il.com>
CC:     <vivien.didelot@...oirfairelinux.com>, <f.fainelli@...il.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <Tristram.Ha@...rel.com>, <andrew@...n.ch>
Subject: RE: [PATCH] DSA support for Micrel KSZ8895

Pavel,

Thanks for update and sorry about email format (due to web-access version)
I'll do review when getting back to office later this week.

- Woojung
________________________________________
From: Pavel Machek [pavel@...x.de]
Sent: Sunday, August 27, 2017 8:36 AM
To: Woojung Huh - C21699; nathan.leigh.conrad@...il.com
Cc: vivien.didelot@...oirfairelinux.com; f.fainelli@...il.com; netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Tristram.Ha@...rel.com; andrew@...n.ch; pavel@...x.de
Subject: [PATCH] DSA support for Micrel KSZ8895

Hi!

So I fought with the driver a bit more, and now I have something that
kind-of-works.

"great great hack" belows worries me.

Yeah, disabled code needs to be removed before merge.

No, tag_ksz part probably is not acceptable. Do you see solution
better than just copying it into tag_ksz1 file?

Any more comments, etc?

Help would be welcome.