netdev - Re: [net-next PATCH 5/9] bpf: more SK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170828173831.n56hfv7bdiowlgfy@ast-mbp>
Date:   Mon, 28 Aug 2017 10:38:33 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     John Fastabend <john.fastabend@...il.com>
Cc:     ast@...nel.org, daniel@...earbox.net, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [net-next PATCH 5/9] bpf: more SK_SKB selftests

On Mon, Aug 28, 2017 at 07:11:24AM -0700, John Fastabend wrote:
> Tests packet read/writes and additional skb fields.
> 
> Signed-off-by: John Fastabend <john.fastabend@...il.com>

Acked-by: Alexei Starovoitov <ast@...nel.org>

>  	{
> +		"invalid access of tc_classid for SK_SKB",
> +		.insns = {
> +			BPF_LDX_MEM(BPF_W, BPF_REG_0, BPF_REG_1,
> +				    offsetof(struct __sk_buff, tc_classid)),
> +			BPF_EXIT_INSN(),
> +		},
> +		.result = REJECT,
> +		.prog_type = BPF_PROG_TYPE_SK_SKB,
> +		.errstr = "invalid bpf_context access",

it shouldn't be readable eight, right?