netdev - Re: [PATCH] ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC 8200"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b84d5301-ba0a-f23a-4f8a-697e3cad1fae@uclouvain.be>
Date:   Mon, 28 Aug 2017 19:48:15 +0100
From:   David Lebrun <david.lebrun@...ouvain.be>
To:     Ahmed Abdelsalam <amsalam20@...il.com>, <davem@...emloft.net>
CC:     <yoshfuji@...ux-ipv6.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv6: sr: fix get_srh() to comply with IPv6 standard "RFC
 8200"

On 08/28/2017 07:20 PM, Ahmed Abdelsalam wrote:
> This patch fixes the get_srh(), so it gets the segment routing header
> regardless of its position in the chain of the extension headers in IPv6
> packet, and makes sure that the IPv6 routing extension header is of
> Type 4.

Ahmed,

You need to initialize srhoff to 0, otherwise ipv6_find_hdr() will crash
the kernel by dereferencing an uninitialized pointer.

Please test your patches before submitting them.

Furthermore, your pskb_may_pull() check should happen right after the
call to ipv6_find_hdr, with srhoff + sizeof(*srh) as argument. Once you
have checked the SRH type, you can then do another pskb_may_pull with
srhoff + len.

David

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)