[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170828123413.2283b2e1@xeon-e3>
Date: Mon, 28 Aug 2017 12:34:13 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Alexander Aring <aring@...atatu.com>
Cc: jhs@...atatu.com, yotamg@...lanox.com, xiyou.wangcong@...il.com,
jiri@...nulli.us, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 1/4] tc: m_ife: allow ife type to zero
On Mon, 28 Aug 2017 15:07:35 -0400
Alexander Aring <aring@...atatu.com> wrote:
> This patch allows to set an ethertype for IFE which is zero. There is no
> kernel side validation which forbids a type to zero.
>
> Signed-off-by: Alexander Aring <aring@...atatu.com>
> ---
> tc/m_ife.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tc/m_ife.c b/tc/m_ife.c
> index e3521e62..e05e2276 100644
> --- a/tc/m_ife.c
> +++ b/tc/m_ife.c
> @@ -63,6 +63,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
> char dbuf[ETH_ALEN];
> char sbuf[ETH_ALEN];
> __u16 ife_type = 0;
> + int user_type = 0;
Please use bool if it is a flag value
Powered by blists - more mailing lists