netdev - Re: [patch net-next 3/3] net/sched: Change act_api and act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8135522-b3e1-0442-ee3f-e29365afae24@mojatatu.com>
Date:   Mon, 28 Aug 2017 17:56:49 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Chris Mi <chrism@...lanox.com>, netdev@...r.kernel.org
Cc:     xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
        mawilcox@...rosoft.com
Subject: Re: [patch net-next 3/3] net/sched: Change act_api and act_xxx
 modules to use IDR

On 17-08-28 02:41 AM, Chris Mi wrote:
> Typically, each TC filter has its own action. All the actions of the
> same type are saved in its hash table. But the hash buckets are too
> small that it degrades to a list. And the performance is greatly
> affected. For example, it takes about 0m11.914s to insert 64K rules.
> If we convert the hash table to IDR, it only takes about 0m1.500s.
> The improvement is huge.
> 
> But please note that the test result is based on previous patch that
> cls_flower uses IDR.
> 
> Signed-off-by: Chris Mi <chrism@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

cheers,
jamal