netdev - Re: [PATCH iproute2 3/4] tc: m_ife: report about kernels default type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc425722-f44f-4009-05af-3b5936c3cc65@mojatatu.com>
Date:   Mon, 28 Aug 2017 18:18:27 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Alexander Aring <aring@...atatu.com>
Cc:     yotamg@...lanox.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 3/4] tc: m_ife: report about kernels default type

Same comment as previous patch.

cheers,
jamal

On 17-08-28 03:07 PM, Alexander Aring wrote:
> This patch will report about if the ethertype for IFE is not specified
> that the default IFE type is used.
> 
> Signed-off-by: Alexander Aring <aring@...atatu.com>
> ---
>   tc/m_ife.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tc/m_ife.c b/tc/m_ife.c
> index 7b57130e..5633ab90 100644
> --- a/tc/m_ife.c
> +++ b/tc/m_ife.c
> @@ -189,6 +189,8 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
>   		addattr_l(n, MAX_MSG, TCA_IFE_DMAC, dbuf, ETH_ALEN);
>   	if (user_type)
>   		addattr_l(n, MAX_MSG, TCA_IFE_TYPE, &ife_type, 2);
> +	else
> +		fprintf(stderr, "IFE type 0x%04X\n", ETH_P_IFE);
>   	if (saddr)
>   		addattr_l(n, MAX_MSG, TCA_IFE_SMAC, sbuf, ETH_ALEN);
>   
>