netdev - Re: [PATCH net-next v2] sched: sfq: drop packets after root qdisc lock is released

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170828.155202.392537637735368038.davem@davemloft.net>
Date:   Mon, 28 Aug 2017 15:52:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gfree.wind@....163.com
Cc:     jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] sched: sfq: drop packets after root qdisc
 lock is released

From: gfree.wind@....163.com
Date: Sat, 26 Aug 2017 22:58:58 +0800

> From: Gao Feng <gfree.wind@....163.com>
> 
> The commit 520ac30f4551 ("net_sched: drop packets after root qdisc lock
> is released) made a big change of tc for performance. But there are
> some points which are not changed in SFQ enqueue operation.
> 1. Fail to find the SFQ hash slot;
> 2. When the queue is full;
> 
> Now use qdisc_drop instead free skb directly.
> 
> Signed-off-by: Gao Feng <gfree.wind@....163.com>

Applied, thank you.