netdev - Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51175933-03ea-2419-b871-e5e9a5955528@mojatatu.com>
Date:   Mon, 28 Aug 2017 18:56:39 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Alexander Aring <aring@...atatu.com>, yotamg@...lanox.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 2/4] tc: m_ife: print IEEE ethertype format

On 17-08-28 06:37 PM, Stephen Hemminger wrote:
> On Mon, 28 Aug 2017 18:18:04 -0400

[..]
>>> @@ -125,7 +125,7 @@ static int parse_ife(struct action_util *a, int *argc_p, char ***argv_p,
>>>    			NEXT_ARG();
>>>    			if (get_u16(&ife_type, *argv, 0))
>>>    				invarg("ife type is invalid", *argv);
>>> -			fprintf(stderr, "IFE type 0x%x\n", ife_type);
>>> +			fprintf(stderr, "IFE type 0x%04X\n", ife_type);
>>>    			user_type = 1;
>>>    		} else if (matches(*argv, "dst") == 0) {
>>>    			NEXT_ARG();
>>>    
>>
> 
> 
> For iproute commands the show output is supposed to match the corresponding set inputs.
> 

These were being printed at parse time ...

cheers,
jamal