netdev - Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170829.094912.1121803194631886017.davem@davemloft.net>
Date:   Tue, 29 Aug 2017 09:49:12 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gregkh@...uxfoundation.org
Cc:     geert@...ux-m68k.org, devel@...verdev.osuosl.org,
        samuel@...tiz.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, sbrivio@...hat.com
Subject: Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete
 it

From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Date: Tue, 29 Aug 2017 16:48:50 +0200

> On Tue, Aug 29, 2017 at 02:11:39PM +0200, Geert Uytterhoeven wrote:
>> Hi Greg,
>> 
>> On Tue, Aug 29, 2017 at 1:28 PM, Greg Kroah-Hartman
>> <gregkh@...uxfoundation.org> wrote:
>> > On Tue, Aug 29, 2017 at 01:11:31PM +0200, Stefano Brivio wrote:
>> >> On Tue, 29 Aug 2017 12:59:00 +0200
>> >> Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>> >> > On Sun, Aug 27, 2017 at 5:03 PM, Greg Kroah-Hartman
>> >> > <gregkh@...uxfoundation.org> wrote:
>> >> > > The IRDA code has long been obsolete and broken.  So, to keep people
>> >> > > from trying to use it, and to prevent people from having to maintain it,
>> >> > > let's move it to drivers/staging/ so that we can delete it entirely from
>> >> > > the kernel in a few releases.
>> >> >
>> >> > (diving into an early boot crash)
>> >> >
>> >> > Have you tried running this? ;-)
>> >> >
>> >> > irda_init() and net_dev_init() are both subsys_initcall()s.
>> >> > But the former now runs before the latter, leading to:
>> >> >
>> >> > Unable to handle kernel NULL pointer dereference at virtual address 00000004
>> >>
>> >> Should be fixed by https://patchwork.ozlabs.org/patch/807006/
>> >> ("[net-next] staging: irda: force to be a kernel module") I guess...
>> >
>> > Yup, that's the fix for this issue.
>> >
>> > Geert, does that fix the problem for you?
>> 
>> Thanks, that patch fixes the crash, obviously.
>> 
>> It does mean you can no longer have IrDA in a non-modular kernel.
> 
> Given that irda doesn't really work, I doubt anyone is going to care
> about it :)

The initialization with everything built-in worked fine before your
changes.