netdev - Re: [PATCH net] sch_multiq: fix double free on init failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpVm0EvXsdcsAR546urmqgkeVgVqhJu=GwgWAhOutjzgyw@mail.gmail.com>
Date:   Tue, 29 Aug 2017 11:59:45 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Roopa Prabhu <roopa@...ulusnetworks.com>
Subject: Re: [PATCH net] sch_multiq: fix double free on init failure

On Tue, Aug 29, 2017 at 11:26 AM, Nikolay Aleksandrov
<nikolay@...ulusnetworks.com> wrote:
> diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c
> index f143b7bbaa0d..b07f8b01aa07 100644
> --- a/net/sched/sch_multiq.c
> +++ b/net/sched/sch_multiq.c
> @@ -259,9 +259,6 @@ static int multiq_init(struct Qdisc *sch, struct nlattr *opt)
>
>         err = multiq_tune(sch, opt);
>
> -       if (err)
> -               kfree(q->queues);
> -
>         return err;

You can fold them to:

    return multiq_tune(sch, opt);

Other than this,

Acked-by : Cong Wang <xiyou.wangcong@...il.com>