netdev - Re: [PATCH net-next v1] amd-xgbe: Interrupt summary bits are h/w version dependent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170829.153124.564367562949459434.davem@davemloft.net>
Date:   Tue, 29 Aug 2017 15:31:24 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     thomas.lendacky@....com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v1] amd-xgbe: Interrupt summary bits are h/w
 version dependent

From: Tom Lendacky <thomas.lendacky@....com>
Date: Mon, 28 Aug 2017 15:29:34 -0500

> There is a difference in the bit position of the normal interrupt summary
> enable (NIE) and abnormal interrupt summary enable (AIE) between revisions
> of the hardware.  For older revisions the NIE and AIE bits are positions
> 16 and 15 respectively.  For newer revisions the NIE and AIE bits are
> positions 15 and 14.  The effect in changing the bit position is that
> newer hardware won't receive AIE interrupts in the current version of the
> driver.  Specifically, the driver uses this interrupt to collect
> statistics on when a receive buffer unavailable event occurs and to
> restart the driver/device when a fatal bus error occurs.
> 
> Update the driver to set the interrupt enable bit based on the reported
> version of the hardware.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@....com>

Applied.