netdev - Re: [PATCH v2 2/3] dt-binding: net: sfp binding documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170830111118.wy62va6sjzsxrgoo@tarshish>
Date:   Wed, 30 Aug 2017 14:11:18 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Russell King <rmk+kernel@....linux.org.uk>,
        netdev@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/3] dt-binding: net: sfp binding documentation

Hi Sergei,

Thanks for reviewing.

On Wed, Aug 30, 2017 at 02:04:11PM +0300, Sergei Shtylyov wrote:
> On 8/30/2017 12:51 PM, Baruch Siach wrote:
> 
> > Add device-tree binding documentation SFP transceivers. Support for SFP
> > transceivers has been recently introduced (drivers/net/phy/sfp.c).
> > 
> > Signed-off-by: Baruch Siach <baruch@...s.co.il>
> > ---
> > v2:
> >    Rename -gpio properties to -gpios
> >    Rename the rate-select-gpio property to rate-select0-gpios
> >    Add the rate-select1-gpios property
> >    Add examples
> > ---
> >   Documentation/devicetree/bindings/net/sff,sfp.txt | 74 +++++++++++++++++++++++
> >   1 file changed, 74 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/net/sff,sfp.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/net/sff,sfp.txt b/Documentation/devicetree/bindings/net/sff,sfp.txt
> > new file mode 100644
> > index 000000000000..1d9c786d6287
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/sff,sfp.txt
> > @@ -0,0 +1,74 @@
> > +Small Form Factor (SFF) Committee Small Form-factor Pluggable (SFP)
> > +Transceiver
> > +
> > +Required properties:
> > +
> > +- compatible : must be "sff,sfp"
> > +
> > +Optional Properties:
> > +
> > +- i2c-bus : phandle of an I2C bus controller for the SFP two wire serial
> > +  interface
> > +
> > +- moddef0-gpios : phandle of the MOD-DEF0 (AKA Mod_ABS) module presence input
> > +  gpio signal
> 
>    Your example shows there's GPIO phandle *and* specifier.

Would "GPIO specifier" be enough here?

[...]

> > +Example #2: Serdes to PHY to SFP connection
> > +
> > +sfp_eth0: sfp-eth0 {
> > +	compatible = "sff,sfp+";
> > +	i2c-bus = <&sfpp0_i2c>;
> > +	los-gpio = <&cps_gpio1 28 GPIO_ACTIVE_HIGH>;
> 
>    You describe "los-gpios" above , not "los-gpio" (which is a deprecated form).

Will fix.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -