netdev - Re: [PATCH net-next 0/3 v10] Add support for rmnet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170829.180557.1826943085634265902.davem@davemloft.net>
Date:   Tue, 29 Aug 2017 18:05:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     subashab@...eaurora.org
Cc:     netdev@...r.kernel.org, fengguang.wu@...el.com, dcbw@...hat.com,
        jiri@...nulli.us, stephen@...workplumber.org,
        David.Laight@...LAB.COM, marcel@...tmann.org, andrew@...n.ch
Subject: Re: [PATCH net-next 0/3 v10] Add support for rmnet driver

From: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Date: Tue, 29 Aug 2017 18:47:55 -0600

> I have updated the locking scheme as follows -

Series applied, but this is not how you write a header posting for a
patch set.

This posting is where you say at a high level what the patch series is
doing, how it is doing it, and why it is doing it that way.

You can explain what changes happened, and why, but that belongs
in the changelog at the end of this posting.  Here you've made
an explaination for one change the entire content of the text.

You not even saying what rmnet is, why we would want to add it to the
kernel, and what it's all about.  So now when someone tries to read
the merge commit that contains this text, they will have no context
about you and me talking about locking and they will thus ask
themselves "what is this person talking about here?  it's not
explaining the patch series at all"