netdev - Re: [patch net-next v2 2/3] net/sched: Change cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38cea4fa-1ca2-1055-0595-4febf3c08e27@mojatatu.com>
Date:   Wed, 30 Aug 2017 08:09:14 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Chris Mi <chrism@...lanox.com>, netdev@...r.kernel.org
Cc:     xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
        mawilcox@...rosoft.com
Subject: Re: [patch net-next v2 2/3] net/sched: Change cls_flower to use IDR

On 17-08-30 02:31 AM, Chris Mi wrote:
> Currently, all filters with the same priority are linked in a doubly
> linked list. Every filter should have a unique handle. To make the
> handle unique, we need to iterate the list every time to see if the
> handle exists or not when inserting a new filter. It is time-consuming.
> For example, it takes about 5m3.169s to insert 64K rules.
> 
> This patch changes cls_flower to use IDR. With this patch, it
> takes about 0m1.127s to insert 64K rules. The improvement is huge.
> 
> But please note that in this testing, all filters share the same action.
> If every filter has a unique action, that is another bottleneck.
> Follow-up patch in this patchset addresses that.
> 
> Signed-off-by: Chris Mi <chrism@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>


BTW: I'd already acked this before but you left it out in this
version.

cheers,
jamal