netdev - Re: [PATCH net 0/9] net/sched: init failure fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58c39495-8667-d983-94ba-b1a242f56945@mojatatu.com>
Date:   Wed, 30 Aug 2017 08:15:37 -0400
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
        netdev@...r.kernel.org
Cc:     edumazet@...gle.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        roopa@...ulusnetworks.com, Lucas Bates <lucasb@...atatu.com>
Subject: Re: [PATCH net 0/9] net/sched: init failure fixes

On 17-08-30 05:48 AM, Nikolay Aleksandrov wrote:
> Hi all,
> I went over all qdiscs' init, destroy and reset callbacks and found the
> issues fixed in each patch. Mostly they are null pointer dereferences due
> to uninitialized timer (qdisc watchdog) or double frees due to ->destroy
> cleaning up a second time. There's more information in each patch.
> I've tested these by either sending wrong attributes from user-spaces, no
> attributes or by simulating memory alloc failure where applicable. Also
> tried all of the qdiscs as a default qdisc.
> 
> Most of these bugs were present before commit 87b60cfacf9f, I've tried to
> include proper fixes tags in each patch.
> 
> I haven't included individual patch acks in the set, I'd appreciate it if
> you take another look and resend them.
> 


Hi Nik,

For all patches:

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

Would you please consider adding all the the tests
you used to create the oopses in selftests? It will ensure this
embarassing bugs get caught should they ever happen again.
If you need help ping Lucas on Cc.

cheers,
jamal