netdev - Re: [PATCH v3 net-next] staging: irda: fix init level for irda core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170830.101532.1535425571044102908.davem@davemloft.net>
Date:   Wed, 30 Aug 2017 10:15:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, netdev@...r.kernel.org,
        samuel@...tiz.org, linux-kernel@...r.kernel.org,
        fengguang.wu@...el.com, geert@...ux-m68k.org
Subject: Re: [PATCH v3 net-next] staging: irda: fix init level for irda core

From: Greg KH <gregkh@...uxfoundation.org>
Date: Wed, 30 Aug 2017 13:16:49 +0200

> When moving the IRDA code out of net/ into drivers/staging/irda/net, the
> link order changes when IRDA is built into the kernel.  That causes a
> kernel crash at boot time as netfilter isn't initialized yet.
> 
> To fix this, move the init call level of the irda core to be
> device_initcall() as the link order keeps this being initialized at the
> correct time.
> 
> Reported-by: kernel test robot <fengguang.wu@...el.com>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
> 
> v3 - just change the initcall level, works so much simpler, thanks to
>      DaveM for the idea.
> v2 - don't force irda to be a module, make the Makefiles put irda back
>      where it was before in the link order.

Applied, thanks for following up on this Greg.