netdev - Re: [PATCH net-next 0/2] tcp: re-add header prediction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170830.112051.1883418035935384084.davem@davemloft.net>
Date:   Wed, 30 Aug 2017 11:20:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     fw@...len.de
Cc:     netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net-next 0/2] tcp: re-add header prediction

From: Florian Westphal <fw@...len.de>
Date: Wed, 30 Aug 2017 19:24:56 +0200

> Eric reported a performance regression caused by header prediction
> removal.
> 
> We now call tcp_ack() much more frequently, for some workloads
> this brings in enough cache line misses to become noticeable.
> 
> We could possibly still kill HP provided we find a different
> way to suppress unneeded tcp_ack, but given we're late in
> the cycle it seems preferable to revert.

Indeed, reverting at this point in the game is the best thing
to do right now.

Applied, thanks.