netdev - Re: [PATCH net-next] ipv6: Use rt6i_idev index for echo replies to a local address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1504063094.11498.112.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Tue, 29 Aug 2017 20:18:14 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com
Subject: Re: [PATCH net-next] ipv6: Use rt6i_idev index for echo replies to
 a local address

On Mon, 2017-08-28 at 13:53 -0700, David Ahern wrote:
> Tariq repored local pings to linklocal address is failing:
> $ ifconfig ens8
> ens8: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
>         inet 11.141.16.6  netmask 255.255.0.0  broadcast 11.141.255.255
>         inet6 fe80::7efe:90ff:fecb:7502  prefixlen 64  scopeid 0x20<link>
>         ether 7c:fe:90:cb:75:02  txqueuelen 1000  (Ethernet)
>         RX packets 12  bytes 1164 (1.1 KiB)
>         RX errors 0  dropped 0  overruns 0  frame 0
>         TX packets 30  bytes 2484 (2.4 KiB)
>         TX errors 0  dropped 0 overruns 0  carrier 0  collisions 0
> 
> $  /bin/ping6 -c 3 fe80::7efe:90ff:fecb:7502%ens8
> PING fe80::7efe:90ff:fecb:7502%ens8(fe80::7efe:90ff:fecb:7502) 56 data bytes
> 
> --- fe80::7efe:90ff:fecb:7502%ens8 ping statistics ---

Note that the presence of this leading --- had the effect of truncating
the merged patch from this point. (all tags were ignored)

> 3 packets transmitted, 0 received, 100% packet loss, time 2043ms
> 
> icmpv6_echo_reply needs to use the rt6i_idev dev index for local traffic
> similar to how icmp6_send does. Convert the change for icmp6_send into a
> helper that can be used in both places. Add the long over due
> skb_rt6_info helper to convert dst on an skb to rt6_info similar to
> skb_rtable for ipv4.
> 
> Fixes: 4832c30d5458 ("net: ipv6: put host and anycast routes on
>        device with address")
> Reported-by: Tariq Toukan <tariqt@...lanox.com>
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---