netdev - Re: [PATCH net] sch_hhf: fix null pointer dereference on init failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <04bea369-e2d9-954a-0da0-eb3ff831a1c7@cumulusnetworks.com>
Date:   Wed, 30 Aug 2017 10:27:20 +0300
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Roopa Prabhu <roopa@...ulusnetworks.com>
Subject: Re: [PATCH net] sch_hhf: fix null pointer dereference on init failure

On 30/08/17 04:24, Cong Wang wrote:
> On Tue, Aug 29, 2017 at 12:02 PM, Nikolay Aleksandrov
> <nikolay@...ulusnetworks.com> wrote:
>> First I did it with the check in the for () conditional, but this is more
>> visible and explicit. Let me know if you'd like the shorter version. :-)
> 
> Or, if you want to make the patch size smaller, just check NULL
> before for():
> 
> if (!q->hh_flows)
>     return;
> 
> for (...)
> 
> Up to you, I have no strong opinion here, slightly prefer a smaller
> one for backport.
> 

Sure, either one is fine with me too. Since I'll be resubmitting these in a set
I'll use the smaller version for this one.

Thanks,
 Nik