netdev - Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3a3328009e7c0ca8d910e1b15ad0b2a@codeaurora.org>
Date:   Thu, 31 Aug 2017 14:34:20 -0600
From:   Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
To:     Colin King <colin.king@...onical.com>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable
 priv

On 2017-08-31 08:07, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> priv is being assigned but is never used, so remove it.
> 
> Cleans up clang build warning:
> "warning: Value stored to 'priv' is never read"
> 
> Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial
> implementation")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> index c8b573d28dcf..bf7455fdafcc 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> @@ -73,9 +73,6 @@ static const struct net_device_ops rmnet_vnd_ops = {
>   */
>  void rmnet_vnd_setup(struct net_device *rmnet_dev)
>  {
> -	struct rmnet_priv *priv;
> -
> -	priv = netdev_priv(rmnet_dev);
>  	netdev_dbg(rmnet_dev, "Setting up device %s\n", rmnet_dev->name);
> 
>  	rmnet_dev->netdev_ops = &rmnet_vnd_ops;

Thanks for fixing this.

Acked-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>