netdev - Re: [patch net-next repost 0/8] mlxsw: Add IPv6 host dpipe table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170831.144320.554040883431439478.davem@davemloft.net>
Date:   Thu, 31 Aug 2017 14:43:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, arkadis@...lanox.com, idosch@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [patch net-next repost 0/8] mlxsw: Add IPv6 host dpipe table

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu, 31 Aug 2017 17:59:11 +0200

> This patchset adds IPv6 host dpipe table support. This will provide the
> ability to observe the hardware offloaded IPv6 neighbors.

Series applied, thanks.

I noticed while reviewing this we are pretty much split on how
to access neigh->primary_key.

Half the code goes "(type *) n->primary_key" and the other half
(mostly in ipv6) goes "(type *) &n->primary_key"

I know both forms are basically equivalent, but consistency
matters :-)