netdev - Re: [RFC net-next 1/8] net: dsa: Allow switch drivers to indicate number of RX/TX queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a530e4c-1932-dcbb-1eaf-fc4c849c5e3f@gmail.com>
Date:   Thu, 31 Aug 2017 21:00:43 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, jiri@...nulli.us, jhs@...atatu.com,
        davem@...emloft.net, xiyou.wangcong@...il.com,
        vivien.didelot@...oirfairelinux.com
Subject: Re: [RFC net-next 1/8] net: dsa: Allow switch drivers to indicate
 number of RX/TX queues



On 08/31/2017 04:44 PM, Andrew Lunn wrote:
> On Wed, Aug 30, 2017 at 05:18:45PM -0700, Florian Fainelli wrote:
>> Let switch drivers indicate how many RX and TX queues they support. Some
>> switches, such as Broadcom Starfighter 2 are resigned with 8 egress
>> queues.
> 
> Marvell switches also have egress queue.
> 
> Does the SF2 have ingress queues? Marvel don't as far as i known.  So
> i wounder if num_rx_queues is useful?

At the moment probably not, since we are not doing anything useful other
than creating the network devices with the indicated number of queues.

> 
> Do switches in general have ingress queues? 

They do, at least the Starfigther 2 has, and from the Broadcom tag you
can get such information (BRCM_EG_TC_SHIFT) and you could presumably
record that queue on the SKB. I don't have an use case for that (yet?).
-- 
Florian