netdev - Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port TC2QOS mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170902174753.GA8981@lunn.ch>
Date:   Sat, 2 Sep 2017 19:47:53 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        vivien.didelot@...oirfairelinux.com, jiri@...nulli.us,
        jhs@...atatu.com, xiyou.wangcong@...il.com
Subject: Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Configure IMP port
 TC2QOS mapping

On Sat, Sep 02, 2017 at 09:32:08AM -0700, Florian Fainelli wrote:
> 
> 
> On 09/02/2017 09:30 AM, Andrew Lunn wrote:
> >> @@ -129,6 +130,14 @@ static void bcm_sf2_imp_setup(struct dsa_switch *ds, int port)
> >>  	reg |= MII_DUMB_FWDG_EN;
> >>  	core_writel(priv, reg, CORE_SWITCH_CTRL);
> >>  
> >> +	/* Configure Traffic Class to QoS mapping, allow each priority to map
> >> +	 * to a different queue number
> >> +	 */
> >> +	reg = core_readl(priv, CORE_PORT_TC2_QOS_MAP_PORT(port));
> >> +	for (i = 0; i < 8; i++)
> >> +		reg |= i << (PRT_TO_QID_SHIFT * i);
> > 
> > Hi Florian
> > 
> > Rather than 8, would ds->num_tx_queues be more descriptive?
> 
> I actually have a patch on top of this which defines a constant for the
> number of queues instead of open coding 8 here. Thanks!

Hi Florian

It sounds like it should be part of 3/4?

   Andrew